Ensure Gateway resource is deleted on shutdown #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submariner Gateway resource is deleted by the syncer when the syncGatewayStatus loop exits but it's run asynchronously from the main function so, due to timing, it may not get deleted on shutdown. This can result in an intermittent gateway failover E2E failure b/c, after deleting the active gateway pod, it ensures the Gateway is fully connected, assuming it's a new instance. But, if the prior Gateway was not deleted, then it will observe the fully connected state of the prior stale Gateway. This can lead to subsequent timing failures where it is assumed the gateway is fully active. Ensure that the Gateway is deleted by running the Gateway syncer synchronously from main and waiting for it to complete on shutdown. Signed-off-by: Tom Pantelis <[email protected]>
|
🤖 Created branch: z_pr2356/tpantelis/gw_failover_e2e_failure |
|
You have successfully added a new Grype configuration |
skitt
approved these changes
Mar 27, 2023
sridhargaddam
approved these changes
Mar 27, 2023
|
🤖 Closed branches: [z_pr2356/tpantelis/gw_failover_e2e_failure] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submariner
Gatewayresource is deleted by the syncer when thesyncGatewayStatusloop exits but it's run asynchronously from the main function so, due to timing, it may not get deleted on shutdown. This can result in an intermittent gateway failover E2E failure b/c, after deleting the active gateway pod, it ensures theGatewayis fully connected, assuming it's a new instance. But, if the priorGatewaywas not deleted, then it will observe the fully connected state of the prior staleGateway. This can lead to subsequent timing failures where it is assumed the gateway is fully active.Ensure that the
Gatewayis deleted by running theGatewaysyncer synchronously from main and waiting for it to complete on shutdown.